Skip to content

Use the stable compiler to install cross #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2020
Merged

Use the stable compiler to install cross #124

merged 1 commit into from
Jun 3, 2020

Conversation

@gkelly
Copy link
Contributor

@gkelly gkelly commented Jun 2, 2020

The cross tool is used during testing, but isn't a direct dependency.
Use the stable compiler when installing it instead of the active
toolchain during Travis tests to prevent having to update the MSRV to
support building cross.

@gkelly gkelly requested a review from a team as a code owner June 2, 2020 19:12
@burrbull
Copy link
Member

burrbull commented Jun 2, 2020

bors try

bors bot added a commit that referenced this pull request Jun 2, 2020
@bors
Try #124:
3d1f704
@bors
Copy link
Contributor

bors bot commented Jun 2, 2020

try

Build failed:

@gkelly
Copy link
Contributor Author

gkelly commented Jun 2, 2020

Okay, so now cross installs but the tool itself now seems to be trying to build something. Continuing looking...

@burrbull
Copy link
Member

burrbull commented Jun 2, 2020

1.36 still needed for crossbeam

@therealprof
Copy link
Contributor

Maybe we should just go GitHub Actions? At least we have a cached cross version to install there.

@gkelly
Copy link
Contributor Author

gkelly commented Jun 2, 2020

1.36 still needed for crossbeam

Ah, okay that's what I was misunderstanding.

@gkelly
Use the stable compiler to install cross
f39e858 
The `cross` tool is used during testing, but isn't a direct dependency.
Use the stable compiler when installing it instead of the active
toolchain during Travis tests to prevent having to update the MSRV to
support building `cross`.

Also update the MSRV to 1.36.0 in support of crossbeam, a transitive
dependency which requires 1.36.0.
@gkelly gkelly mentioned this pull request Jun 2, 2020
Merged
@gkelly
Copy link
Contributor Author

gkelly commented Jun 2, 2020

I tested the equivalent process here:

$ rustup default 1.36.0
$ rustup install stable
$ cargo +stable install cross
$ cross version
cargo 1.36.0 (c4fcfb725 2019-05-15)
$ cross build --all-features
$ cross test --release --all-features

@adamgreig
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jun 2, 2020
@bors
Try #124:
f6e9e76
@bors
Copy link
Contributor

bors bot commented Jun 2, 2020

try

Build succeeded:

@gkelly
Copy link
Contributor Author

gkelly commented Jun 2, 2020

@Emilgardis, you had a concern about the version bump in the other (closed) PR?

therealprof
therealprof requested changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.36 is fine but requires according documentation in the README.

@gkelly
Copy link
Contributor Author

gkelly commented Jun 3, 2020

1.36 is fine but requires according documentation in the README.

I updated the Minimum Supported Rust Version (MSRV) heading (https://github.com/rust-embedded/svd/pull/124/files#diff-04c6e90faac2675aa89e2176d2eec7d8) in README.md, is there something else that should be added?

therealprof
therealprof approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed that. LGTM.

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 3, 2020

Build succeeded:

@bors bors bot merged commit 675e0bc into rust-embedded:master Jun 3, 2020
@gkelly gkelly deleted the stable-cross branch June 3, 2020 00:40
@Emilgardis
Copy link
Member

No concerns from me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@therealprof therealprof therealprof approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gkelly @burrbull @therealprof @adamgreig @Emilgardis