Skip to content

Conversation

@eldruin
Copy link
Member

@eldruin eldruin commented Sep 20, 2021

  • Raised MSRV to 1.46.0 due to nix
  • Updated nix
  • Renamed use_tokio feature async-tokio like in gpio-cdev. (The word "use" is discouraged in feature names: C-FEATURE)
  • Fixed docs link
  • Use GHA for CI instead of Travis (tested on my fork)
  • Added embedded-linux team to authors

Fixes #66

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ryankurte (or someone else) soon.

Please see the contribution instructions for more information.

@eldruin
Copy link
Member Author

eldruin commented Sep 21, 2021

bors try

bors bot added a commit that referenced this pull request Sep 21, 2021
@eldruin eldruin mentioned this pull request Sep 21, 2021
Copy link
Member

@posborne posborne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates LGTM. I think one additional thing we could add that was requested elsewhere would be the specify features as part of package.metadata.docs.rs in order to include the tokio docs in what gets published to docs.rs.

@eldruin
Copy link
Member Author

eldruin commented Sep 21, 2021

Sounds good. I will add that in a separate PR, thanks!

@eldruin eldruin merged commit 12b60cf into rust-embedded:master Sep 21, 2021
@eldruin eldruin deleted the updates branch September 21, 2021 20:36
@bors
Copy link
Contributor

bors bot commented Sep 21, 2021

try

Timed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MSRV build on CI is broken due to dependencies

4 participants