Add builders for registers #98
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am thinking that for common registers, just |
|
Move to staging as there are quite a lot changes. |
romancardenas
pushed a commit
that referenced
this pull request
Nov 17, 2023
98: Convert default_setup_interrupts into a Rust function r=dkhayes117 a=Disasm First step towards a fully inline-asm `riscv-rt`. Co-authored-by: Vadim Kaushan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rework of #77. In #77, there is detailed explaination about why this is needed.
I have taken advices that we should add a new type to store values of registers like
mstatus.So I added
MstatusBuilderandMstatusValueto resolve this issue.MstatusBuildercontains a set of setters that can construct a value formstatusregister.MstatusValueis only able to write to the physical register and take effect.As this is a rather big change, I plan to open this PR as a request for comments.
If this style is okay, I will work in a few days implementing and documenting for other registers.
Thanks in advance for your valuable comments.