Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add singleton macro #87

Merged
merged 1 commit into from
Jan 6, 2022
Merged

add singleton macro #87

merged 1 commit into from
Jan 6, 2022

Conversation

gnxlxnxx
Copy link
Contributor

professionally copied this macro from the cortex-m crate

@gnxlxnxx gnxlxnxx requested a review from a team as a code owner October 18, 2021 08:26
@Disasm
Copy link
Member

Disasm commented Oct 18, 2021

This macro is unsound on multi-core systems. This should be documented appropriately.

bors bot added a commit to rust-embedded/cortex-m that referenced this pull request Nov 25, 2021
362: add note r=jonathanpallant a=gnxlxnxx

the same note as in rust-embedded/riscv#87

Co-authored-by: gnxlxnxx <[email protected]>
Copy link
Member

@Disasm Disasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Disasm
Copy link
Member

Disasm commented Jan 6, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 6, 2022

@bors bors bot merged commit 8357d8d into rust-embedded:master Jan 6, 2022
romancardenas pushed a commit that referenced this pull request Nov 17, 2023
87: release v0.8.1 r=Disasm a=almindor

Release v0.8.1 to fix #85 

Co-authored-by: Ales Katona <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants