feat(indexmap): added truncate
#526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamburus
force-pushed
the
feature/indexmap/truncate
branch
3 times, most recently
from
f28a771 to
e21472a
Compare
|
Thanks for the PR. Could you add tests? |
reitermarkus
reviewed
Apr 5, 2025
reitermarkus
force-pushed
the
feature/indexmap/truncate
branch
2 times, most recently
from
68687ef to
8c754d1
Compare
reitermarkus
force-pushed
the
feature/indexmap/truncate
branch
from
8c754d1 to
1e7f5b8
Compare
reitermarkus
approved these changes
Apr 5, 2025
|
There is a doc test, I think that's enough. I changed the order to 3, 2, 1 so it is more obvious what should happen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
truncatemethod toIndexMap.See corresponding truncate in the indexmap crate.
Related pull requests:
get_index,get_index_mutandget_index_of#525