VecView: Implement serialize #453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This probably does not need a changelog entry since |
sosthene-nitrokey
force-pushed
the
vecview-ser
branch
from
62c5823
to
932cbfb
Compare
|
The error seems to be caused by the Rust 1.76 release changing the error message. Maybe the Rust version should be pinned for CI. |
sosthene-nitrokey
force-pushed
the
vecview-ser
branch
from
932cbfb
to
f3f0c02
Compare
sosthene-nitrokey
force-pushed
the
vecview-ser
branch
from
021b2c2
to
8bd0a04
Compare
sosthene-nitrokey
force-pushed
the
vecview-ser
branch
from
8bd0a04
to
98241c9
Compare
sosthene-nitrokey
force-pushed
the
vecview-ser
branch
from
98241c9
to
3f6ae0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept the initial implementation on
Vec, but is there any reason why it doesn't use the implementation ofSerializefor[T]?