bus: make constructors set CS high. #594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a footgun where a HAL makes OutputPins low by default (or the user sets them to low and doesn't notice).
eldruin
approved these changes
Apr 23, 2024
Member
eldruin
left a comment
eldruin
left a comment
There was a problem hiding this comment.
Thank you!
I do not like that a constructor has side-effects, even worse, potentially fallible ones.
However, I agree with the overall assessment in the meeting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a footgun where a HAL makes OutputPins low by default (or the user sets
them to low and doesn't notice).
Discussed in today's WG meeting.