Skip to content

Add + ?Sized to all blanket impls. #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eldruin merged 1 commit into from
Jul 12, 2023
Merged

Add + ?Sized to all blanket impls. #470

eldruin merged 1 commit into from
Jul 12, 2023

Conversation

@Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Jul 12, 2023

It doesn't make much of a difference in practice because unsized types are rare, but it's best practice to do so, so why not.

@Dirbaio Dirbaio requested a review from a team as a code owner July 12, 2023 13:20
eldruin
eldruin approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, thanks!

@eldruin eldruin enabled auto-merge July 12, 2023 15:54
@eldruin eldruin added this pull request to the merge queue Jul 12, 2023
Merged via the queue into master with commit ae327b8 Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eldruin eldruin eldruin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dirbaio @eldruin