Add MSRV configuration to CI #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldruin
requested review from
a team,
ilya-epifanov and
thejpster
as code owners
|
r? @ithinuel (rust_highfive has picked a reviewer for you, use r? to override) |
|
thanks for the PR! seems like a good addition to me, can we also add a note to the readme as per here? |
|
@ryankurte Sure. It is done now. |
|
Ok, badges will be discussed in rust-embedded/wg#443. |
|
bors r+ |
Build succeeded |
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compatibility with the MSRV should be checked by the CI. At the moment that is Rust 1.35.0 due to this issue.
The MSRV and its update process should probably also be documented in the README.