Skip to content

Fix inline assembly. #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2022
Merged

Fix inline assembly. #432

merged 2 commits into from
Apr 23, 2022

Conversation

@reitermarkus
Copy link
Member

Fix some differences between previous asm.S and inline assembly.

@reitermarkus reitermarkus requested a review from a team as a code owner April 22, 2022 12:23
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @therealprof (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m labels Apr 22, 2022
@adamgreig
Copy link
Member

Thanks, good catch on the cmp especially. Is there any need for the 4: label, do you think? I guess you already noticed we have to use movs instead of mov for that immediate load; the old asm.S loaded a literal from a constant pool but I think this way is a little quicker and takes a little less space.

@reitermarkus
Copy link
Member Author

Is there any need for the 4: label, do you think?

I guess not since it's not actually used.

adamgreig
adamgreig approved these changes Apr 23, 2022
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 23, 2022

Build succeeded:

@bors bors bot merged commit ec7f7c9 into rust-embedded:master Apr 23, 2022
@reitermarkus reitermarkus deleted the fix-asm branch April 24, 2022 01:49
@adamgreig adamgreig mentioned this pull request Aug 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamgreig adamgreig adamgreig approved these changes

Assignees

@therealprof therealprof

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@reitermarkus @rust-highfive @adamgreig @therealprof