Skip to content

Fix most clippy lints #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2022
Merged

Fix most clippy lints #415

merged 2 commits into from
Jan 23, 2022

Conversation

@newAM
Copy link
Member

@newAM newAM commented Jan 23, 2022 •
edited
Loading

This fixes all clippy lints that do not result in a user-visible change, and result in valid code for the 1.40 MSRV.

@rust-highfive
Copy link

rust-highfive commented Jan 23, 2022

r? @adamgreig

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m labels Jan 23, 2022
@newAM newAM marked this pull request as ready for review January 23, 2022 18:19
@newAM newAM requested a review from a team as a code owner January 23, 2022 18:19
@newAM
Copy link
Member Author

newAM commented Jan 23, 2022

Should be good now, I forgot matches! was introduced in 1.42.

@adamgreig
Copy link
Member

adamgreig commented Jan 23, 2022

Since this is in the master branch for the 0.8 series, maybe it's worth bumping MSRV to 1.42 and getting matches in. I wouldn't be surprised if we end up wanting a newer MSRV for other 0.8 features anyway.

adamgreig
adamgreig approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 23, 2022

Build succeeded:

@bors bors bot merged commit 0811180 into rust-embedded:master Jan 23, 2022
@newAM newAM deleted the fix-clippy branch January 23, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamgreig adamgreig adamgreig approved these changes

Assignees

@adamgreig adamgreig

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@newAM @rust-highfive @adamgreig