-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependence on embedded-hal for Delay #344
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @adamgreig (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
I don't understand the inline bit, so LMK what you're looking for there. |
src/delay.rs
Outdated
|
||
/// Delay using the Cortex-M systick for a certain duration, ms. | ||
pub fn delay_ms(&mut self, ms: u32) { | ||
self.delay_us(ms * 1_000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation is correct not for all argument values. Please see the delay_ms
implementation below.
Fixed, and took a stab at |
I don't think it's a good idea to inline the main |
Changed, and made the u32-conversion syntax consistent (went with |
@David-OConnor I think |
Done |
Co-authored-by: Vadim Kaushan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
bors merge
Build succeeded: |
345: Prepare for v0.7.3 r=therealprof a=adamgreig We've had #337 merged for a while and it seems like it would be helpful for users to get it released, and now #344 to go with it. No other changes since then (except a small doc change) so it should be an easy release. Co-authored-by: Adam Greig <[email protected]>
Fixes #343
No functional changes. Allows you to use Delay as previously, or without including or importing
embedded-hal
.