Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent calling rustc_version::version_meta() multiple times #101

Closed
wants to merge 5 commits into from
Closed

Prevent calling rustc_version::version_meta() multiple times #101

wants to merge 5 commits into from

Commits on Feb 7, 2021

  1. Prevent calling rustc_version::version_meta() multiple times 

    The custom `ArcError` maybe removed once Rust 1.51 released:
https://doc.rust-lang.org/nightly/std/error/trait.Error.html#impl-Error-33.
    @EFanZh
    EFanZh committed Feb 7, 2021
    Configuration menu
    Copy the full SHA
    a88d44f View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. No need to use Arc

    @EFanZh
    EFanZh committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    29aeb2f View commit details
    Browse the repository at this point in the history

  2. No need to implement Clone now

    @EFanZh
    EFanZh committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    ea81e6d View commit details
    Browse the repository at this point in the history

  3. Avoid create new Strings

    @EFanZh
    EFanZh committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    5e2e97c View commit details
    Browse the repository at this point in the history

  4. Use Into::into for type conversion

    @EFanZh
    EFanZh committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    ab6b4a1 View commit details
    Browse the repository at this point in the history