-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated deps #52
Updated deps #52
Conversation
- Updating cortex-m from 0.6 to 0.7 - Updated cortex-m-rt from 0.6 to 0.7 in /examples - Updated cortex-m-semihosting from 0.3.2 to 0.5 in /examples - Pointing to github repo (for now) for tm4c129x and tm4c123x deps
@amcelroy Could you update this to use the published versions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
Just confirmed that the new crates.io version 0.9.1 for tm4c123x is working (we don't have a tm4c129x, but presumably it works) with our current project using RTIC v1.1.4. The last commit reverts the dependencies from the github repo to crates.io. Thanks for helping maintain this library, we have really appreciated using it to get into Rust using it since we still use the TM4C123 for a couple of projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, before the merge, could you add an entry about the updates to the README files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also update the version of the tm4c-hal
and add an entry to its readme as well?
Co-authored-by: Diego Barrios Romero <[email protected]>
Co-authored-by: Diego Barrios Romero <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I have now published the new versions of the crates. |
Howdy,
I'd like to submit for review some changes to the Cargo.toml files to upgrade the dependencies to use with more modern dependencies, such as RTIC v1. We recently started a project in RTIC v1 for the Max32660 and I wanted to upgrade an older TM4C project that used RTIC v0.5.
To do this, I had to change some of the code in the dslite2svd crate in commit #77a40f0. I was hoping to get this version released on crates.io but after discussing with the maintainer they tagged the repo as v0.9.1 and we agreed to try and submit a PR to this project using the git repo + tag instead of trying to update crates.io for the tm4c123x and tm4c129x dependencies.
I've been using the upgraded HAL with RTIC v1 and haven't noticed any issues with GPIO, EEPROM, UART, Timers, ADC, and SPI. The project has been behaving similarly to
Thanks for considering!