Fixing bug in Result<T>
when T
is a primitive that requires modification in the Kotlin code generation
#693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modification applied to primitives when returned as a result were specified in the wrong order in the Kotlin code generation.
For example, the following Rust:
Generated the following Kotlin, with the bug specified with a comment:
The buggy line should actually be
return (returnVal.union.ok.toUInt()).ok()
. This CL fixes the bug, foru32
and for all other primitives that require modification on return as aRes
in Kotlin.