env hack to deal with sccache issues #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
addresses #295 |
messense
reviewed
Dec 16, 2024
| @@ -106,7 +106,10 @@ impl Zig { | |||
| .and_then(|index| cmd_args.get(index + 1)); | |||
| let target_info = TargetInfo::new(target); | |||
|
|
|||
| let rustc_ver = rustc_version::version()?; | |||
| let rustc_ver = match env::var("CARGOZIGBUILD_RUSTC_VERSION") { | |||
There was a problem hiding this comment.
Suggested change
| let rustc_ver = match env::var("CARGOZIGBUILD_RUSTC_VERSION") { | |
| let rustc_ver = match env::var("CARGO_ZIGBUILD_RUSTC_VERSION") { |
| @@ -512,6 +515,11 @@ impl Zig { | |||
| .map(|target| target.split_once('.').map(|(t, _)| t).unwrap_or(target)) | |||
| .collect::<Vec<&str>>(); | |||
| let rustc_meta = rustc_version::version_meta()?; | |||
| Self::add_env_if_missing( | |||
| cmd, | |||
| "CARGOZIGBUILD_RUSTC_VERSION", | |||
There was a problem hiding this comment.
Suggested change
| "CARGOZIGBUILD_RUSTC_VERSION", | |
| "CARGO_ZIGBUILD_RUSTC_VERSION", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does: adds
CARGOZIGBUILD_RUSTC_VERSION(idk what else to name it) variable that is used byZig::execute_compilerto avoid callingsccache rustc -vVin some cases