Add windows docker image #292
Conversation
vedantmgoyal9
force-pushed
the
patch-1
branch
2 times, most recently
from
5708918 to
e723b31
Compare
|
@messense I have tested the image and it is working. Can you please review, merge and create a release, so I can add reference to images published officially instead of building own from my fork? |
| ``` | ||
| > [!NOTE] | ||
| > Windows docker image can compile debug builds, but does NOT support `cargo build --release` for *-apple-darwin targets. | ||
| > You will get ```error: unable to run `strip`: program not found```. If you know a solution to this, please open an issue and/or PR. |
There was a problem hiding this comment.
This might be caused by rust-lang/rust#131206 which is fixed in nightly and expected to be released in 1.83.0.
There was a problem hiding this comment.
@messense I tested with nightly; it still outputs the same error.
On a side note, I don't think the Windows image will be used much, except in Windows runners. Once Windows runners support WSL2, then we can use the existing Linux-based docker image, and Windows-based image will be pretty much useless. Also, I could have simply used Linux runners to run Linux-based docker image, but a project I'm contributing to, are little hesitant to make a significant change to their CI.
|
FYI, the windows container building is broken at the moment: https://github.com/rust-cross/cargo-zigbuild/actions/runs/12092913178/job/33723240315 |
@messense I've created and tested this Dockerfile locally.
However, I'm not familiar with uploading the image to ghcr.io/DockerHub. Please update the Release workflow accordingly.Thank you 😃Edit: The PR is now ready-to-merge. I've updated the Release workflow.