-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend musl weak symbols mapping #180
extend musl weak symbols mapping #180
Conversation
Use symbols found from http://git.musl-libc.org/cgit/musl/ header files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I don't think we need to add constants because usually they're just a #define
in C, you can't refer to it in Rust so it's not needed here.
Co-authored-by: messense <[email protected]>
Co-authored-by: messense <[email protected]>
Co-authored-by: messense <[email protected]>
Thanks for the assist. I leaned towards adding add |
It'd be great if you can confirm that this actually fixes #179 for your project, thanks! |
Just added a comment that our project builds on this PR. #179 (comment) |
Extending the musl weak symbol mappings to resolve #179.
The symbol list was generated via scrapping the header files from the musl source code at (http://git.musl-libc.org/cgit/musl/)
fyi: I'm fairly new at the compiler stuff, so if this PR went to far than I'm happy to adjust as directed.