Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend musl weak symbols mapping #180

Merged
merged 4 commits into from
Sep 11, 2023

Conversation

reubenmiller
Copy link
Contributor

Extending the musl weak symbol mappings to resolve #179.

The symbol list was generated via scrapping the header files from the musl source code at (http://git.musl-libc.org/cgit/musl/)

fyi: I'm fairly new at the compiler stuff, so if this PR went to far than I'm happy to adjust as directed.

Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I don't think we need to add constants because usually they're just a #define in C, you can't refer to it in Rust so it's not needed here.

src/linux/mod.rs Outdated Show resolved Hide resolved
src/linux/mod.rs Outdated Show resolved Hide resolved
src/linux/mod.rs Outdated Show resolved Hide resolved
reubenmiller and others added 3 commits September 11, 2023 07:01
@reubenmiller
Copy link
Contributor Author

Thanks!

I don't think we need to add constants because usually they're just a #define in C, you can't refer to it in Rust so it's not needed here.

Thanks for the assist. I leaned towards adding add #defines since it was generally easier to remove than add.

@messense
Copy link
Member

It'd be great if you can confirm that this actually fixes #179 for your project, thanks!

@reubenmiller
Copy link
Contributor Author

It'd be great if you can confirm that this actually fixes #179 for your project, thanks!

Just added a comment that our project builds on this PR. #179 (comment)

@messense messense enabled auto-merge September 11, 2023 05:35
@messense messense disabled auto-merge September 11, 2023 05:35
@messense messense enabled auto-merge (squash) September 11, 2023 05:35
@messense messense merged commit 00297c9 into rust-cross:main Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants