Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unsupported linker arg: -exported_symbols_list #164

Closed
sigmaSd opened this issue Aug 26, 2023 · 2 comments · Fixed by #171 or #273
Closed

unsupported linker arg: -exported_symbols_list #164

sigmaSd opened this issue Aug 26, 2023 · 2 comments · Fixed by #171 or #273

Comments

@sigmaSd
Copy link

sigmaSd commented Aug 26, 2023

error: unsupported linker arg: -exported_symbols_list

I understand that zig 0.11.0 errors on unrecognized flags, should unknown flags be hardcoded ? if that's the case I can add it to zig.rs
@messense
Copy link
Member

Feel free to send a PR.

serjflint pushed a commit to serjflint/cargo-zigbuild that referenced this issue Sep 10, 2023
fix zig: unsupported exported_symbols_list
7b5eda1 
Relates: rust-cross#164
@serjflint serjflint mentioned this issue Sep 10, 2023
Merged
@messense messense linked a pull request Sep 10, 2023 that will close this issue
fix zig: unsupported exported_symbols_list #171
Merged
@messense
Copy link
Member

Partially fixed by #171, -Wl,-exported_symbols_list,<path> is handled but -Wl,-exported_symbols_list <path> isn't handled yet.

serjflint pushed a commit to serjflint/cargo-zigbuild that referenced this issue Sep 10, 2023
typo zig: remove dash
9039f51 
Relates: rust-cross#164
@serjflint serjflint mentioned this issue Sep 10, 2023
Merged
@messense messense mentioned this issue Sep 13, 2024
Open
rfairfax added a commit to rfairfax/cargo-zigbuild that referenced this issue Sep 17, 2024
@rfairfax
fix: Handle -Wl,-exported_symbols_list <path>
6cb233d 
When building a targeting a macos target you may get an error such as:

error: unsupported linker arg: -exported_symbols_list

A previous fix addressed the first variant of this flag where it is one argument.
This fix addresses the second form of this flag where the symbols list is passed
as a file path via a follow up argument.

Repros by building a cdylib targetting aarch64-apple-darwin.

Fixes rust-cross#164
@rfairfax rfairfax mentioned this issue Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@messense @sigmaSd