chore(ci): Fix typo in Dockerfile comment#830
Closed
gap-editor wants to merge 1 commit intorust-bitcoin:masterfrom
Closed
chore(ci): Fix typo in Dockerfile comment#830gap-editor wants to merge 1 commit intorust-bitcoin:masterfrom
gap-editor wants to merge 1 commit intorust-bitcoin:masterfrom
Conversation
Member
|
You are not allowed to edit files in secp256k1-sys/depend/secp256k1. If you want to change these, please PR upstream at https://github.com/bitcoin-core/secp256k1/. |
Author
hi. i have created same PR in bitcoin-core/secp256k1 and it has been merged. maybe we should re-open thisone? :) |
Member
|
Thanks! No, we will get the typo fix the next time we update our vendored copy of libsecp256k1. (Which I guess we should do sometime soon, since it's been a while.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the spelling of "dpkg-dev" in a comment within the Dockerfile.
The comment explains the reason for installing the
dpkg-devpackage..