Skip to content

Define field/scalar impl in secp256k1-sys/build.rs#285

Closed
fanatid wants to merge 1 commit intorust-bitcoin:masterfrom
fanatid:field-scalar-impl
Closed

Define field/scalar impl in secp256k1-sys/build.rs#285
fanatid wants to merge 1 commit intorust-bitcoin:masterfrom
fanatid:field-scalar-impl

Conversation

@fanatid
Copy link
Contributor

@fanatid fanatid commented Mar 8, 2021

No description provided.

@elichai
Copy link
Member

elichai commented Mar 9, 2021

These are autodetected by the C code: bitcoin-core/secp256k1#793
Have you found a case where the wrong values were chosen? (for example USE_SCALAR_4X64 on a 32bit machine or USE_FIELD_10X26 on a 64 bit machine)

EDIT: These macros are no longer a thing, #793 changed it such that there's only SECP256K1_WIDEMUL_INT128 and SECP256K1_WIDEMUL_INT64 (still if you found a case where the wrong one was chosen that will be interesting)

@fanatid
Copy link
Contributor Author

fanatid commented Mar 9, 2021

I did not know that these autodetected now 🤦‍♂️

@fanatid fanatid closed this Mar 9, 2021
@fanatid fanatid deleted the field-scalar-impl branch March 9, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants