Pin dependencies when using MSRV #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cargo already uses an env var to configure the toolchain `RUSTUP_TOOLCHAIN`, there is no need for our custom `TOOLCHAIN` environment variable.
A recent release of `form_urlencoded` breaks our dev build when using 1.41.1 toolchain. Pin the `url` and `form_urlencoded` dependencies when on 1.41.1 toolchain.
tcharding
force-pushed
the
09-12-pin-dependencies
branch
from
e5146fa to
c6d89cd
Compare
apoelstra
approved these changes
Sep 12, 2022
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
c6d89cd910af787c7f12f139713bba2c7662e07f Pin dependencies when using MSRV (Tobin C. Harding)
15b57cd9b5d0a8f02e3762f4371189ee0252ce7f Remove TOOLCHAIN (Tobin C. Harding)
Pull request description:
A recent release of `form_urlencoded` breaks our test run when using 1.41.1 toolchain.
Pin the `url` and `form_urlencoded` dependencies when on 1.41.1 toolchain. Add a section to the readme instructing devs how to pin relevant dependencies (only when running tests).
ACKs for top commit:
apoelstra:
ACK c6d89cd910af787c7f12f139713bba2c7662e07f
Tree-SHA512: bff67d12b344c70f6f787e12b5640ea0bba6a8a460e6116f42c2049d7fc8e370157b37884ef0a9dc765e5cef852786cae50a53ef1785b6f45640d6a061d146ea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent release of
form_urlencodedbreaks our test run when using 1.41.1 toolchain.Pin the
urlandform_urlencodeddependencies when on 1.41.1 toolchain. Add a section to the readme instructing devs how to pin relevant dependencies (only when running tests).