Automated daily update to rustc (to nightly-2024-03-20)

[apoelstra]

Automated update to Github CI workflow rust.yml by create-pull-request GitHub action

[coveralls]

Pull Request Test Coverage Report for Build 8368078636

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 83.913%

---

Totals
Change from base Build 8366578065:	0.0%
Covered Lines:	19873
Relevant Lines:	23683

---

💛 - Coveralls

[apoelstra]

Neat! It does run CI, but it uses my name as the PR author. I guess I'm okay with that.

[tcharding]

If you are the author then someone else will have to ack, I was planning on just acking mechanically and not doing any checks - just stating in case something else is expected.

[tcharding]

ACK 5d078ce

[apoelstra]

@tcharding sgtm. The point of this pinning is to avoid CI breaking out from under us, so in theory CI is the only check that we need.

[tcharding]

Seems like the system is working, our code does not build cleanly with this version of nightly so we shouldn't merge it, right - we have to do the update manually? Did you guys have a timeframe in mind for how often that should be done? Within a week, within a month, just when we get round to it?

[apoelstra]

@tcharding yes, we have to do the update manually. But right now there is no fix. See rust-lang/rust-clippy#12436

We should fix this "as soon as possible".

[tcharding]

ACK b9bb1b9

[apoelstra]

Still failing and no update on our clippy issues.