releases: increase MSRV to 1.74.0 #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Actually even with 1.74 the dependencies listed in Cargo.lock don't work. I'll spend some time trying to fix this. |
We cannot build `releases` with the existing lockfile because its MSRV is too high. If we intend the MSRV to be lower then we need to fix the lockfile and reduce the MSRV in `cargo-rbmt`.
apoelstra
force-pushed
the
2025-12/msrv
branch
from
a86daa4 to
73c9f6b
Compare
We are very close to being formatted, so just run the formatter to get us all the way.
Collaborator
|
@tcharding what is the status of the |
Member
Author
|
Personally I think we should fold it into |
nyonson
approved these changes
Dec 4, 2025
Member
|
Fold it in. FTR I have not looked at it since it was created (I don't even remember writing it if it was me). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot build
releaseswith the existing lockfile because its MSRV is too high. If we intend the MSRV to be lower then we need to fix the lockfile and reduce the MSRV incargo-rbmt.