Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

hex: allow specifying a width when printing hashes #9

Merged
merged 2 commits into from
May 4, 2019
Merged

hex: allow specifying a width when printing hashes #9

merged 2 commits into from
May 4, 2019

Conversation

apoelstra
Copy link
Member

No description provided.

sgeisler
sgeisler reviewed Dec 13, 2018
View reviewed changes
src/hex.rs Outdated Show resolved Hide resolved
sgeisler
sgeisler reviewed Dec 13, 2018
View reviewed changes
src/hex.rs Outdated Show resolved Hide resolved
@apoelstra
Copy link
Member Author

Rebased and added commit to separate out "width" from "precision".

@sgeisler can you re-review?

sgeisler
sgeisler approved these changes May 4, 2019
View reviewed changes
Copy link
Contributor

@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the concurrent usage of precision and width might lead to strange behavior, but imo nobody will (nor should they) do this.

@apoelstra apoelstra merged commit 6c06428 into master May 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dongcarl dongcarl dongcarl left review comments

@sgeisler sgeisler sgeisler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apoelstra @sgeisler @dongcarl