This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Add sha256::Midstate type #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
reviewed
Apr 28, 2019
apoelstra
reviewed
Apr 28, 2019
apoelstra
reviewed
Apr 28, 2019
apoelstra
reviewed
Apr 28, 2019
|
You need to change the type of |
stevenroose
force-pushed
the
sha256-midstate
branch
3 times, most recently
from
faa02e0
to
bd75e6c
Compare
apoelstra
reviewed
May 2, 2019
apoelstra
reviewed
May 2, 2019
stevenroose
force-pushed
the
sha256-midstate
branch
from
bd75e6c
to
29053f6
Compare
stevenroose
force-pushed
the
sha256-midstate
branch
from
bd2eb0b
to
2dab3d6
Compare
apoelstra
reviewed
May 20, 2019
src/sha256.rs
Outdated
| @@ -209,6 +209,20 @@ macro_rules! round( | |||
| ); | |||
|
|
|||
| impl HashEngine { | |||
| /// Create a new [HashEngine] from a midstate. | |||
| /// | |||
| /// Be aware that this method only works when [length] is a multiple of the block size. | |||
There was a problem hiding this comment.
Can you assert! this? Ok if you add it in a separate commit @stevenroose
|
ACK except nit |
|
Added blocksize multiple assertion in separate commit. |
apoelstra
approved these changes
May 22, 2019
shesek
added a commit
to shesek/electrs
that referenced
this pull request
May 24, 2019
Unimplemented for re-issuance transactions. Depends on an umerged PR to bitcoin_hashes (ttps://github.com/rust-bitcoin/bitcoin_hashes/pull/39)
shesek
added a commit
to shesek/electrs
that referenced
this pull request
Jun 23, 2019
Unimplemented for re-issuance transactions. Depends on an umerged PR to bitcoin_hashes (ttps://github.com/rust-bitcoin/bitcoin_hashes/pull/39)
shesek
added a commit
to shesek/electrs
that referenced
this pull request
Jun 24, 2019
Unimplemented for re-issuance transactions. Depends on an umerged PR to bitcoin_hashes (ttps://github.com/rust-bitcoin/bitcoin_hashes/pull/39)
shesek
added a commit
to shesek/electrs
that referenced
this pull request
Jun 29, 2019
Unimplemented for re-issuance transactions. Depends on an umerged PR to bitcoin_hashes (ttps://github.com/rust-bitcoin/bitcoin_hashes/pull/39)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #40.
In Elements we use this type to represent witness merkle roots and Asset IDs.