This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Add all_zeros method to Hash trait #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we use `Default::default()` to get an all zeros hash. This is misleading because an all zeroes hash does not have a real meaning since there is no known input to create it. The all zeros has is used by the Bitcoin network to signify certain things (e.g. the previous blockhash in the genesis block). Remove the `Default` implementation from the `Hash` trait and add a `all_zeros` method instead.
Whats the policy for changes like this across the rust-bitcoin stack? Should this PR have included a change to bump the version number or do we rely on you to work this out when you do the release? |
|
@tcharding we don't have an explicit policy ... but yes, "we rely on me to work it out" is usually what we do. Sometimes people want a minor version bump for some specific feature, in which case I ask them to put the bump into the PR ... but for major ones I don't think we ever do that. |
Merged
|
Friendly bump please review crew. |
|
Let's do it. We can bring this into the MSRV-bumping release, this crate is simple enough that I don't worry about breaking too much at once. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use
Default::default()to get an all zeros hash. This is confusing because an all zeroes hash does not have a real meaning since there is no known input to create it. The all zeros hash is, however used by the Bitcoin network to signify certain things (e.g. the previous blockhash in the genesis block).Remove the
Defaultimplementation from theHashtrait and add aall_zerosmethod instead. Remove theDefaultderive from any hash type that has it.To see the patch to
rust-bitcointhat this PR imposes, check out this branch.Resolves #139