-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Loosen acceptable types to support current linux build on aarch64 #415
fix: Loosen acceptable types to support current linux build on aarch64 #415
Conversation
Same for |
Don't build for Windows and some Linux versions: - Building HTSlib on Windows is not possible. - Building HTSlib does not work on Linux: - x86: len() as u64 is not valid on 32-bit - aarch64 and ppc64le: - expected `*mut u8`, found `&mut i8` - Fixed by: rust-bio/rust-htslib#415 - Building zlib-ng does not work for all Linux targets: - armv7: - Might get fixed in the future if zig gets fixed: ziglang/zig#10411
Don't build for Windows and some Linux versions: - Building HTSlib on Windows is not possible. - Building HTSlib does not work on Linux: - x86: - len() as u64 is not valid on 32-bit - aarch64 and ppc64le: - expected `*mut u8`, found `&mut i8` - Fixed by: rust-bio/rust-htslib#415 - Building zlib-ng does not work for all Linux targets: - armv7: - Might get fixed in the future if zig gets fixed: ziglang/zig#10411 - s390: - Error: Unrecognized opcode: `stfle'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aarch64 does not support i8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@johanneskoester I assume it is because of this: https://abstractexpr.com/2023/04/30/the-anomaly-of-the-char-type-in-c/ |
…-htslib is fixed. Enable support for building for aarch64 and ppc64le on Linux now rust-htslib is fixed. See: rust-bio/rust-htslib#415
That article is spot on, it is fundamentally because the signedness of char is different across platforms. There are definitely better ways to fix this long term, but luckily the range of values here is so small that taking half of the i8 range is sufficient. Thanks! |
Fixes #412