Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict the bitvec->funty dependency to <=1.1 #1286

Merged
merged 1 commit into from
Feb 15, 2021
Merged

Restrict the bitvec->funty dependency to <=1.1 #1286

merged 1 commit into from
Feb 15, 2021

Conversation

nickelc
Copy link
Contributor

@nickelc nickelc commented Feb 14, 2021

Nom builds fail since the release of funty 1.2.
see #1283 / pull/1283/checks

Alternative would be to bump the version of bitvec to 0.21

bitvec depends on `funty` 1.0 but bitvec 0.19.x is incompatible with `funty` 1.2
@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.652% when pulling d915250 on nickelc:restrict-bitvec-funty into 28d18a6 on Geal:master.

rfk added a commit to mozilla/uniffi-rs that referenced this pull request Feb 15, 2021
This is basically copying the upstream fix proposed for `nom`, until we
get a new release with the fix included.

Ref rust-bakery/nom#1286
rfk added a commit to mozilla/uniffi-rs that referenced this pull request Feb 15, 2021
This is basically copying the upstream fix proposed for `nom`, until we
get a new release with the fix included.

Ref rust-bakery/nom#1286
@therealprof
Copy link

@nickelc Thanks for sharing this observation, I was just scratching my at this weird breakage and can confirm that restricting the funty version in my application Cargo.toml works.

@Geal Geal merged commit dba1e0a into rust-bakery:master Feb 15, 2021
@Geal
Copy link
Collaborator

Geal commented Feb 15, 2021

thank you, I'm pushing a release right away

@nickelc nickelc deleted the restrict-bitvec-funty branch February 15, 2021 09:00
@nickelc
Copy link
Contributor Author

nickelc commented Feb 15, 2021

Apparently this fixes the nom builds but not projects depending on nom :(

cargo up --dry-run
    Updating crates.io index
    Updating funty v1.1.0 -> v1.2.0
    Updating nom v6.1.0 -> v6.1.1
    Updating redox_syscall v0.2.4 -> v0.2.5

@therealprof
Copy link

@nickelc Hm, seems you're right... 😟 bitvec is the culprit pulling the version up and that can only be overridden by the application.

funty v1.2.0
└── bitvec v0.19.4
    └── nom v6.1.1

@nickelc
Copy link
Contributor Author

nickelc commented Feb 15, 2021

nom 6.1.2 fixed it.

@Geal thank you

@Geal
Copy link
Collaborator

Geal commented Feb 15, 2021

Yes, 6.1.1 was not enough, there was a small fix to add, now it works 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants