-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variation in capitalization of "type" #226
Comments
Hey Axel, that's very interesting, it looks like the upstream may not have an appropriate struct tags. Is this just some rich text? How can I reproduce this? |
NVM, was able to reproduce
|
There's no implementation for the RichTextElement, and it falls back to this
There's no tags on this struct, therefore you see it as is — as "Type" and "Raw". Looking at the PR queue for slack lib, it doesn't look very promising: i.e. someone submitted the PR to add support Rich Text Lists (slack-go/slack#1155) in January and it's still unmerged, chances are high that this won't be resolved soon, so you might need to implement a temporary workaround. I'll see into creating a PR to add support for preformatted blocks, but it would be outside of my control to tell you when it's going to be merged. |
It's not a problem for me, my
|
Cool, thanks for raising this, I wasn't aware. Yes, there's a bunch of them, and "rich_text_list" in particular is this one: slack-go/slack#1155 waiting for the time to come for someone to merge it :) |
Submitted the PR to slack repo to add rich_text_quote and rich_text_preformatted slack-go/slack#1260, the rich_text_list was merged yesterday. |
Hey @svenssonaxel, good news, this change was merged upstream, and i just updated the master, will be available in next patch. |
The block elements have a
type
field, but sometimes it's in lowercase, sometimes capitalized.The text was updated successfully, but these errors were encountered: