fix race condition in downloader

rusq · Mar 19, 2024 · d730bf6 · d730bf6
1 parent cf084c0
commit d730bf6
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/downloader/downloader.go b/downloader/downloader.go
@@ -321,10 +321,9 @@ var ErrNotStarted = errors.New("downloader not started")
 // filesystem.
 func (c *Client) DownloadFile(dir string, f slack.File) (string, error) {
 	c.mu.Lock()
-	started := c.started
-	c.mu.Unlock()
+	defer c.mu.Unlock()
 
-	if !started {
+	if !c.started {
 		return "", ErrNotStarted
 	}
 	c.fileRequests <- fileRequest{Directory: dir, File: &f}