Don't use colors when used in web browsers
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to have module bundlers like Webpack leave out the `colors` dependency in the resulting browser bundle (e.g. for use with universal apps). Also, use the safe API of `colors`, which doesn't extend `String.prototype`.
Fixes tests (`TypeError: Forked processes must have an IPC channel` issue).
ingmarh
force-pushed
the
no-colors-in-web-browsers
branch
from
99c6106
to
5e7d2cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a universal app, we want to use
postcss-wrapalso on the client-side with Webpack. Unfortunately, our build fails withCritical dependencieswarnings caused by this issue with thecolorspackage.This change allows to have module bundlers like Webpack leave out the
colorsdependency in the resulting browser bundle (e.g. for use with universal apps).colorsdoesn't seem to work in web browsers anyway.Also, use the safe API of
colors, which doesn't extendString.prototype.