Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

password spec #32

Merged
merged 3 commits into from
May 30, 2019
Merged

password spec #32

merged 3 commits into from
May 30, 2019

Conversation

Kleak
Copy link
Contributor

@Kleak Kleak commented May 18, 2019

No description provided.

@Kleak Kleak requested a review from bwnyasse May 18, 2019 21:43
@Kleak Kleak self-assigned this May 18, 2019
@Kleak Kleak added this to the MVP milestone May 18, 2019
import "models/tag.proto";

message Password {
string id = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we must also add 'url'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String url = 6

import "models/tag.proto";

message Password {
string id = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String url = 6

@Kleak Kleak requested a review from bwnyasse May 30, 2019 15:43
@bwnyasse bwnyasse merged commit a346a06 into master May 30, 2019
@bwnyasse bwnyasse deleted the spec-passwords-service branch May 30, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants