Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec tags service #28

Merged
merged 4 commits into from
May 18, 2019
Merged

spec tags service #28

merged 4 commits into from
May 18, 2019

Conversation

Kleak
Copy link
Contributor

@Kleak Kleak commented May 17, 2019

will close #6

will close #6
@Kleak Kleak requested a review from bwnyasse May 17, 2019 08:57
@Kleak Kleak self-assigned this May 17, 2019
@Kleak Kleak added this to the MVP milestone May 17, 2019
@Kleak Kleak mentioned this pull request May 17, 2019
Copy link
Contributor

@bwnyasse bwnyasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we also need a description field ?
if not what it's label ?
I mean

message Tag {
  string id = 1;
  string label = 2;
  string description = 3;
  string color = 4;
} 

@Kleak Kleak requested a review from bwnyasse May 18, 2019 08:07
@bwnyasse bwnyasse merged commit 99b7eaa into master May 18, 2019
@bwnyasse bwnyasse deleted the spec-tags-service branch May 18, 2019 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spec tags service
2 participants