-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to a new MLKit library which runs on-device #150
base: master
Are you sure you want to change the base?
Conversation
Thanks for this @danhunsaker! I'll try to find time this weekend to review this :) |
@danhunsaker will you be interested in becoming a maintainer of this plugin? I and @Kleak don't have much time to maintain it so if you're interested it might be cool to have you on board :) |
On android look like the play/pause button doesn't work anymore but the rest looks ok and works great! On iOS I'm not able to run the example, I get that:
|
I think i can commit to that, sure. :)
Hmm. I didn't even see any buttons on my end, other than the one that triggers the camera in the first place... I'll have to look harder.
That's an oversight I'm correcting now. My only macOS box is a VM that won't let me install the extensions that give me access to the host files, so it's slower than it should be. But it's coming soon! |
3dcf365
to
52ced2f
Compare
Everything should build now, but unfortunately, I can't actually run the simulator to test the app itself. The moment I enable nested virtualization so the simulator can run, the kernel panics and refuses to boot. Probably the AMD CPU I'm running everything on. 😀 Took the liberty of fixing the code analysis run while I was in the codebase anyway. |
Cool let me run that in my iphone and see how it goes :D |
So I managed to compile/install it on iOS but for now it doesn't work, the image freeze. I'll try to dig into that when I have more time ^^ |
cbaa381
to
69bf507
Compare
Google is moving away from Firebase for most of MLKit, so we should use the new on-device library, too.