Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to a new MLKit library which runs on-device #150

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

danhunsaker
Copy link
Contributor

Google is moving away from Firebase for most of MLKit, so we should use the new on-device library, too.

@jaumard
Copy link
Collaborator

jaumard commented Dec 3, 2021

Thanks for this @danhunsaker! I'll try to find time this weekend to review this :)

@jaumard
Copy link
Collaborator

jaumard commented Dec 5, 2021

@danhunsaker will you be interested in becoming a maintainer of this plugin? I and @Kleak don't have much time to maintain it so if you're interested it might be cool to have you on board :)

@jaumard
Copy link
Collaborator

jaumard commented Dec 5, 2021

On android look like the play/pause button doesn't work anymore but the rest looks ok and works great!

On iOS I'm not able to run the example, I get that:

[!] CocoaPods could not find compatible versions for pod "FirebaseInstallations":
  In Podfile:
    FirebaseMLVisionBarcodeModel (= 0.21) was resolved to 0.21.0, which depends on
      FirebaseMLVision (= 7.3.0-beta) was resolved to 7.3.0-beta, which depends on
        FirebaseMLCommon (= 7.3.0-beta) was resolved to 7.3.0-beta, which depends on
          FirebaseInstallations (~> 7.0)

    google_ml_kit (from `.symlinks/plugins/google_ml_kit/ios`) was resolved to 0.6.0, which depends on
      GoogleMLKit/LinkFirebase (~> 2.2.0) was resolved to 2.2.0, which depends on
        MLKitLinkFirebase (~> 1.3.0) was resolved to 1.3.0, which depends on
          FirebaseInstallations (~> 8.0)

CocoaPods could not find compatible versions for pod "MLKitXenoCommon":
  In Podfile:
    google_ml_kit (from `.symlinks/plugins/google_ml_kit/ios`) was resolved to 0.6.0, which depends on
      GoogleMLKit/PoseDetection (~> 2.2.0) was resolved to 2.2.0, which depends on
        MLKitPoseDetection (~> 1.0.0-beta4) was resolved to 1.0.0-beta5, which depends on
          MLKitXenoCommon (= 1.0.0-beta5)

    google_ml_kit (from `.symlinks/plugins/google_ml_kit/ios`) was resolved to 0.6.0, which depends on
      GoogleMLKit/PoseDetectionAccurate (~> 2.2.0) was resolved to 2.2.0, which depends on
        MLKitPoseDetectionAccurate (~> 1.0.0-beta4) was resolved to 1.0.0-beta4, which depends on
          MLKitXenoCommon (= 1.0.0-beta4)

@danhunsaker
Copy link
Contributor Author

@danhunsaker will you be interested in becoming a maintainer of this plugin?

I think i can commit to that, sure. :)

On android look like the play/pause button doesn't work anymore but the rest looks ok and works great!

Hmm. I didn't even see any buttons on my end, other than the one that triggers the camera in the first place... I'll have to look harder.

On iOS I'm not able to run the example

That's an oversight I'm correcting now. My only macOS box is a VM that won't let me install the extensions that give me access to the host files, so it's slower than it should be. But it's coming soon!

@danhunsaker
Copy link
Contributor Author

Everything should build now, but unfortunately, I can't actually run the simulator to test the app itself. The moment I enable nested virtualization so the simulator can run, the kernel panics and refuses to boot. Probably the AMD CPU I'm running everything on. 😀

Took the liberty of fixing the code analysis run while I was in the codebase anyway.

@jaumard
Copy link
Collaborator

jaumard commented Dec 6, 2021

Cool let me run that in my iphone and see how it goes :D
Thanks!

@jaumard
Copy link
Collaborator

jaumard commented Dec 6, 2021

So I managed to compile/install it on iOS but for now it doesn't work, the image freeze. I'll try to dig into that when I have more time ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants