-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use LLVM backend Python package #2849
Conversation
python-poetry/poetry#5273 (comment) when debian packaging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not clear to me how these changes would integrate with #2858 . You probably should coordinate in that regard and one of these two should be merged first. Probably that one, not this one.
@@ -1,3 +1,3 @@ | |||
/k-distribution/include/kframework/builtin/* @dwightguth @ehildenb | |||
/Jenkinsfile @runtimeverification/admin | |||
/.github/workflows/* @runtimeverification/admin | |||
/Jenkinsfile @runtimeverification/admin @F-WRunTime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's probably more appropriate to just add Freeman to the admin team than to explicitly hardcode his username here.
Yes, I started working on this PR before I was aware of the work ongoing to pull Pyk out into its own repo. I will be coordinating with @tothtamas28 on the best way to get these changes working under that setup.. |
This supersedes the draft changes in #2844 with a more robust solution as suggested by @tothtamas28.
The changes in this PR add the kllvm bindings as a "path" dependency to pyk, and updates the nix flake build accordingly. It also adds a trivial test case to make sure that pyk can call into the bindings correctly.
Because we point to a relative path dependency for the bindings library, we need to perform a few more steps for
pyk
'smake install
target. This issue gives some more context.