-
Notifications
You must be signed in to change notification settings - Fork 6
refactor: not forcing network volumes, increased default sizes (volumes and containers), locking endpoints to EU-RO-1 #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+103
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make name field required instead of optional with default factory - Remove auto-generation complexity and user_provided_name tracking - Simplify resource_id logic since name is always present - Increase default size from 50GB to 100GB This simplifies the NetworkVolume API by requiring explicit naming and removes the complexity around tracking name origins.
- Add datacenter field to ServerlessResource with EU_RO_1 default - Automatically sync datacenter to locations field for API compatibility - Add validation to ensure network volume datacenter matches endpoint - Remove automatic network volume creation for simpler logic - Add datacenter to _input_only to prevent GraphQL field errors This ensures all endpoints are locked to EU_RO_1 datacenter by default while allowing user override and preventing datacenter mismatches.
- Remove test_deploy_without_name_always_creates_new - Remove test_resource_id_fallback_for_unnamed_volumes These tests are no longer valid since name is now required. Keeps tests for named volume behavior which still apply.
… tests - Add tests for datacenter defaults to EU_RO_1 - Add tests for datacenter override capability - Add tests for locations field sync from datacenter - Add tests for datacenter validation between endpoint and volume - Replace default volume creation test with no-volume behavior test - Update deployment test to verify locations field is set Tests now cover the new datacenter locking mechanism and validation while removing tests for the removed auto-volume creation behavior.
- Add DataCenter to public exports in __init__.py - Add DataCenter to core resources exports This allows users to import and use DataCenter enum for specifying datacenters when creating endpoints and volumes.
Updates PodTemplate containerDiskInGb default to provide more reasonable disk space for container workloads.
pandyamarut
approved these changes
Aug 15, 2025
Contributor
pandyamarut
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
pandyamarut
pushed a commit
that referenced
this pull request
Sep 9, 2025
…es and containers), locking endpoints to EU-RO-1 (#82) * refactor: require name field for NetworkVolume and simplify API - Make name field required instead of optional with default factory - Remove auto-generation complexity and user_provided_name tracking - Simplify resource_id logic since name is always present - Increase default size from 50GB to 100GB This simplifies the NetworkVolume API by requiring explicit naming and removes the complexity around tracking name origins. * feat: add datacenter locking and validation for endpoints - Add datacenter field to ServerlessResource with EU_RO_1 default - Automatically sync datacenter to locations field for API compatibility - Add validation to ensure network volume datacenter matches endpoint - Remove automatic network volume creation for simpler logic - Add datacenter to _input_only to prevent GraphQL field errors This ensures all endpoints are locked to EU_RO_1 datacenter by default while allowing user override and preventing datacenter mismatches. * test: remove tests for unnamed NetworkVolume behavior - Remove test_deploy_without_name_always_creates_new - Remove test_resource_id_fallback_for_unnamed_volumes These tests are no longer valid since name is now required. Keeps tests for named volume behavior which still apply. * test: add datacenter validation tests and remove auto-volume creation tests - Add tests for datacenter defaults to EU_RO_1 - Add tests for datacenter override capability - Add tests for locations field sync from datacenter - Add tests for datacenter validation between endpoint and volume - Replace default volume creation test with no-volume behavior test - Update deployment test to verify locations field is set Tests now cover the new datacenter locking mechanism and validation while removing tests for the removed auto-volume creation behavior. * feat: export DataCenter enum for public API - Add DataCenter to public exports in __init__.py - Add DataCenter to core resources exports This allows users to import and use DataCenter enum for specifying datacenters when creating endpoints and volumes. * feat: increase default container disk size from 10GB to 64GB Updates PodTemplate containerDiskInGb default to provide more reasonable disk space for container workloads. * fix: deleted
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Core Features
ServerlessResourceinstances default toDataCenter.EU_RO_1datacenterfield automatically syncs tolocationsfield for API compatibilitydatacenterorlocationsparametersNetworkVolume Simplification
namefield is now required instead of auto-generatedVolume Management Changes
API Improvements
DataCenterenum now available in public APITest Plan
Breaking Changes
NetworkVolume.nameis now required (was optional with auto-generation)PodTemplate.containerDiskInGbdefault increased from 10GB to 64GBMigration Guide