test: Add comprehensive serverless resource tests, refactor, and bug fix #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
deanq
commented
Aug 7, 2025
deanq
commented
- Add complete test cases for ServerlessResource and its supporting classes
- Fix serialize_instance_ids method to handle None values properly
- Remove unused is_ready_for_requests method and cleanup code
- Fix test_endpoint_property_with_id by mocking runpod.api_key - Fix test_deploy_failure_raises_exception by mocking network volume deployment and API key environment variable - Both tests now pass correctly without making actual API calls
pandyamarut
pushed a commit
that referenced
this pull request
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.