Polish #76
Merged
Polish #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jorghi12
reviewed
Jul 31, 2023
| return HeartbeatSender._instance | ||
|
|
||
| async def start_ping(self): | ||
| async def start_ping(self, test=False): |
There was a problem hiding this comment.
That's pretty clever. I hadn't considered refactoring in this sort of way to improve tests.
Jorghi12
reviewed
Jul 31, 2023
|
|
||
| # Success case | ||
| await new_ping._send_ping() # pylint: disable=protected-access | ||
| await new_ping.start_ping(test=True) |
There was a problem hiding this comment.
Great improvement. Tests should definitely use the exposed methods, and not methods meant to be private/protected.
Jorghi12
reviewed
Jul 31, 2023
| await new_ping._send_ping() # pylint: disable=protected-access | ||
| assert mock_log_error.call_count == 2 | ||
| await new_ping.start_ping(test=True) | ||
| assert mock_log_error.call_count == 1 |
There was a problem hiding this comment.
Great improvement. Tests should definitely use the exposed methods, and not methods meant to be private/protected.
Jorghi12
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing I noticed that ping would timeout and then not restart, fixed that and then fixed the corresponding tests.