Skip to content

Retire sls-core since we're no longer developing it #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

Retire sls-core since we're no longer developing it #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 0 additions & 87 deletions .github/tests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,92 +57,5 @@
"value3"
]
}
},
{
"hardwareConfig": {
"endpointConfig": {
"name": "runpod-python E2E Test - Serverless Core - Basic",
"gpuIds": "ADA_24,AMPERE_16,AMPERE_24,AMPERE_48,AMPERE_80"
},
"templateConfig": {
"env": [
{
"key": "RUNPOD_USE_CORE",
"value": "true"
}
]
}
},
"input": {
"mock_return": "this worked!"
}
},
{
"hardwareConfig": {
"endpointConfig": {
"name": "runpod-python E2E Test - Serverless Core - Long Job",
"gpuIds": "ADA_24,AMPERE_16,AMPERE_24,AMPERE_48,AMPERE_80"
},
"templateConfig": {
"env": [
{
"key": "RUNPOD_USE_CORE",
"value": "true"
}
]
}
},
"input": {
"mock_return": "Delay test successful returned after waiting 5 minutes.",
"mock_delay": 300
}
},
{
"hardwareConfig": {
"endpointConfig": {
"name": "runpod-python E2E Test - Serverless Core - Generator Handler",
"gpuIds": "ADA_24,AMPERE_16,AMPERE_24,AMPERE_48,AMPERE_80"
},
"templateConfig": {
"dockerArgs": "python3 -u /handler.py --generator --return_aggregate_stream",
"env": [
{
"key": "RUNPOD_USE_CORE",
"value": "true"
}
]
}
},
"input": {
"mock_return": [
"value1",
"value2",
"value3"
]
}
},
{
"hardwareConfig": {
"endpointConfig": {
"name": "runpod-python E2E Test - Serverless Core - Async Generator Handler",
"gpuIds": "ADA_24,AMPERE_16,AMPERE_24,AMPERE_48,AMPERE_80"
},
"templateConfig": {
"dockerArgs": "python3 -u /handler.py --async_generator --return_aggregate_stream",
"env": [
{
"key": "RUNPOD_USE_CORE",
"value": "true"
}
]
}
},
"input": {
"mock_return": [
"value1",
"value2",
"value3"
]
}
}
]
4 changes: 0 additions & 4 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ __pycache__/
*.py[cod]
*$py.class

# C extensions
*.so
!sls_core.so

# Distribution / packaging
.Python
build/
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,4 +71,4 @@ dependencies = { file = ["requirements.txt"] }

# Used by pytest coverage
[tool.coverage.run]
omit = ["runpod/_version.py", "runpod/serverless/core.py"]
omit = ["runpod/_version.py",]
14 changes: 0 additions & 14 deletions runpod/serverless/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
import time
from typing import Any, Dict

from runpod.serverless import core

from ..version import __version__ as runpod_version
from . import worker
from .modules import rp_fastapi
Expand Down Expand Up @@ -171,17 +169,5 @@ def start(config: Dict[str, Any]):
)
return

# --------------------------------- SLS-Core --------------------------------- #

if os.getenv("RUNPOD_SLS_CORE") is None and os.getenv("RUNPOD_USE_CORE") is not None:
log.warn("RUNPOD_USE_CORE is deprecated. Please use RUNPOD_SLS_CORE instead.")
core.main(config)
return

elif os.getenv("RUNPOD_SLS_CORE","false").lower() in ["1", "t", "true"]:
core.main(config)
return

# --------------------------------- Standard --------------------------------- #
worker.main(config)
return
Loading
Loading