Add allowed CUDA versions parameter to endpoint creation #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new parameter `allowed_cuda_versions` to the `create_endpoint` function and the corresponding GraphQL mutation generator `generate_endpoint_mutation`. This parameter allows specifying a comma-separated list of allowed CUDA versions for the endpoint. The parameter is added to the GraphQL mutation as new field and is expected to enhance control over the CUDA environment for endpoints. - The `allowed_cuda_versions` parameter is added with a default value of "12.1,12.2,12.3,12.4,12.5". - The parameter is also included in the GraphQL mutation string. - Redundant documentation and example code in `create_endpoint` have been removed to streamline the function's docstring.
This commit introduces the `gpu_count` parameter to the `create_endpoint` function in `ctl_commands.py` and the `generate_endpoint_mutation` function in `mutations/endpoints.py`. The `gpu_count` parameter allows specifying the number of GPUs to be used by an endpoint. This change includes the necessary updates to the function signatures and the GraphQL mutation string construction to support the new parameter.
deanq
approved these changes
Jan 3, 2025
deanq
added a commit
that referenced
this pull request
May 23, 2025
This corrects some of the changes from #375
deanq
added a commit
that referenced
this pull request
May 23, 2025
This corrects some of the changes from #375
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new parameter
allowed_cuda_versionsto thecreate_endpointfunction and thecorresponding GraphQL mutation generator
generate_endpoint_mutation. This parameter allows specifying acomma-separated list of allowed CUDA versions for the endpoint. The parameter is added to the GraphQL mutation as
new field and is expected to enhance control over the CUDA environment for endpoints.
allowed_cuda_versionsparameter is added with a default value of "12.1,12.2,12.3,12.4,12.5".create_endpointhave been removed to streamline the function's docstring.