Skip to content

fix: checking for status #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2023
Merged

fix: checking for status #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion runpod/serverless/modules/rp_http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ async def _handle_result(session, job_data, job, url_template, log_message):
log.error(f"Error while returning job result {job['id']}: {err}")

finally:
if url_template == JOB_DONE_URL and job.get('status', None) != 'IN_PROGRESS':
if url_template == JOB_DONE_URL and job_data.get('status', None) != 'IN_PROGRESS':
job_list.remove_job(job["id"])
log.info(f'{job["id"]} | Finished')

Expand Down
6 changes: 6 additions & 0 deletions runpod/serverless/modules/rp_progress.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,11 @@

import aiohttp

from runpod.serverless.modules.rp_logger import RunPodLogger
from .rp_http import send_result

log = RunPodLogger()

async def _create_session_async():
"""
Creates an aiohttp session.
Expand Down Expand Up @@ -48,6 +51,8 @@ async def main():
await _async_progress_update(session, job, progress)

loop.run_until_complete(main())

log.debug(f'{job["id"]} | Progress Update Sent: {progress}')
finally:
loop.close()

Expand All @@ -56,5 +61,6 @@ def progress_update(job, progress):
"""
Updates the progress of a currently running job in a separate thread.
"""
log.debug(f'{job["id"]} | Sending Progress Update: {progress}')
thread = threading.Thread(target=_thread_target, args=(job, progress), daemon=True)
thread.start()