Fix rope_scaling dict parsing #195
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Code42Cate was your test without the env var also succesful? |
TimPietrusky
approved these changes
Jul 8, 2025
|
The docker images are updated on this? Is this now working? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #192 by correctly parsing the expected (https://github.com/vllm-project/vllm/blob/main/vllm/engine/arg_utils.py#L354C5-L354C17) json to a dict instead of just passing the string
Tested by deploying to Runpod with
Menlo/Jan-nano-128kandROPE_SCALING={"rope_type":"yarn","factor":3.2,"original_max_position_embeddings":40960}Still waiting for the build to test if it works without specifying the env var