Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: view modal title展示有误 #919

Merged
merged 2 commits into from
Mar 3, 2022

Conversation

TMBigGroup
Copy link
Contributor

view 新建和编辑 数据视图和目录 title都显示为“数据视图”

@@ -28,6 +28,7 @@ interface SaveFormModel {
}

interface SaveFormState {
viewType?: 'folder' | 'view';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议这里不用加 viewType,而是使用 simple 来判断是数据视图/目录即可

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已优化

@scottsut scottsut merged commit 0339f43 into running-elephant:dev Mar 3, 2022
@scottsut
Copy link
Contributor

scottsut commented Mar 3, 2022

Thanks for the contribution!

@TMBigGroup TMBigGroup deleted the local/folder branch March 9, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants