feat: Save to Dashboard popup adds an entry for a create dashboard #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cuiyansong
reviewed
Jul 20, 2022
| @@ -18,6 +18,7 @@ | |||
|
|
|||
| import { Empty, Table, TableProps } from 'antd'; | |||
| import classNames from 'classnames'; | |||
| import { TABLEDATAINDEX } from 'globalConstants'; | |||
There was a problem hiding this comment.
常量命名，尽量还是大写单词加下划线的方式，连起来不利于阅读：TABLE_DATA_INDEX?
Cuiyansong
reviewed
Jul 20, 2022
frontend/src/globalConstants.ts
Outdated
| @@ -25,6 +25,7 @@ export const EVENT_ACTION_DELAY_MS = 200; | |||
| export const RUNTIME_FILTER_KEY = Symbol('@filters@'); | |||
| export const BOARD_COPY_CHART_SUFFIX = '_copy'; | |||
| export const BOARD_SELF_CHART_PREFIX = 'widget_'; | |||
| export const TABLEDATAINDEX = '@datartTableIndex@'; | |||
Cuiyansong
reviewed
Jul 20, 2022
| @@ -1657,6 +1657,7 @@ | |||
| "searchValue": "Search keywords" | |||
| }, | |||
| "saveToDashOrStory": { | |||
| "creatdDashboard": "Create Dashboard", | |||
There was a problem hiding this comment.
createDashboard，不是creatd
Cuiyansong
reviewed
Jul 20, 2022
| @@ -1658,6 +1658,7 @@ | |||
| "searchValue": "搜索名称关键字" | |||
| }, | |||
| "saveToDashOrStory": { | |||
| "creatdDashboard": "新建仪表板", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.