Fix create source form display and label consistencies #1668
Conversation
|
local npm run test:ci passed. Do I need submit PR again?
|
|
For the "node ci action" failed, you should be add prettier.js plugin for your IDE and format the SourceDetailPage/index.tsx file, then add a new commit to fix format error. |
Thank you for guidance, this is done and now tests passed. Please help review. |
| @@ -481,21 +481,20 @@ export function SourceDetailPage() { | |||
| </Form.Item> | |||
| {dataProviderConfigTemplateLoading && <LoadingOutlined />} | |||
|
|
|||
| {(providerType !== 'FILE' || formType === CommonFormTypes.Edit) && | |||
There was a problem hiding this comment.
@lyp000119 what is provider type file and format type edit, is it necessary？
There was a problem hiding this comment.
Fyi, I removed it as I see the condition is wrong. On demo site, if I start create a new FILE source, the form does not appear due to this condition. Not sure the reason for having it in the existing code.
There was a problem hiding this comment.
@lyp000119 什么是provider type file和format type edit，有必要吗？
It can be modified like this, no problem
|
This display issue was previously raised #1177 However, issue still there on demo site. |
|
Thank you! |
|
Thanks for the contribution! |
| @@ -527,7 +526,7 @@ const Content = styled.div` | |||
| } | |||
|
|
|||
| .detailForm { | |||
| max-width: ${SPACE_TIMES(240)}; | |||
| max-width: ${SPACE_TIMES(400)}; | |||
There was a problem hiding this comment.
The current JDBC screen has the field labels truncated. See the last few fields below.
There was a problem hiding this comment.
The current JDBC screen has the field labels truncated. See the last few fields below.
Roger that 👌
Hello
This is for #1292
Please help review. Screenshots after fix are attached in above issue page. Also remove the condition at line 484 to display the form when provider FILE is selected.