Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

计算字段验证失败Modal会直接关闭 #578

Closed
TMBigGroup opened this issue Jan 11, 2022 · 2 comments
Closed

计算字段验证失败Modal会直接关闭 #578

TMBigGroup opened this issue Jan 11, 2022 · 2 comments
Labels
improvement New feature or request

Comments

@TMBigGroup
Copy link
Contributor

场景
1.图表模块新增计算字段
2.计算字段验证报错，Modal直接关闭了

期望
验证失败不要关闭，方便进行二次修改
@Cuiyansong Cuiyansong added the improvement New feature or request label Jan 11, 2022
@Cuiyansong
Copy link
Contributor

目前验证是接受了Modal的回调再验证的，可以考虑验证前置，这样需求也是合理的，方案还得再研究一下。

@TMBigGroup
Copy link
Contributor Author

对的，验证失败了，modal也被关闭且销毁了。再次打开还需要重复输入信息，使用起来有点不太舒服。

TMBigGroup pushed a commit to TMBigGroup/datart that referenced this issue Jan 12, 2022
fix: onOK关闭逻辑优化.issue running-elephant#578
d785598
scottsut added a commit that referenced this issue Jan 14, 2022
@scottsut
Merge pull request #587 from TMBigGroup/local/dev
bcf5b1c 
fix: onOK关闭逻辑优化.issue #578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@scottsut @Cuiyansong @TMBigGroup