Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datachart过滤条件类型为包含的时候，如果清除掉输入的值会报错 #1754

Closed
KANLON opened this issue Jul 27, 2022 · 2 comments
Closed

datachart过滤条件类型为包含的时候，如果清除掉输入的值会报错 #1754

KANLON opened this issue Jul 27, 2022 · 2 comments
Assignees
@Cuiyansong @SoarBlueSky @qxqzx13
Labels
discussion improvement New feature or request need signoff in pre-release Validating this bug
Milestone
RC.1

Comments

@KANLON
Copy link
Contributor

KANLON commented Jul 27, 2022 •
edited
Loading

Datart Version
版本: 1.0.0-rc.0

Describe the bug
datachart过滤条件类型为包含的时候，如果清除掉输入的值会报错

To Reproduce
Steps to reproduce the behavior:

  1. 从view进入分析页面，选择某些字段为筛选条件
  2. 设置文本类型的筛选条件为 条件，"包含",如下图，并且随便输入一个默认值

image

  1. 保存，查看该datachart表格
  2. 在表格筛选条件中，把默认值去掉，报错了

image

Expected behavior
应该清空掉默认值不报错，处理的数据结果应该是不过滤的数据结果的

Screenshots
image

Environmental details: (optional, depending on where the bug occurs)

  • Windows 10
  • Chrome/103.0.0.0

Additional context
http://datart-demo.retech.cc/organizations/b14ac7aed7f54ad986f5644f06f4a77d/vizs/0a3a2cd083ca4380a6412210006caf8d
直接访问这个demo页面，把过滤器去掉就可以看到结果
@Cuiyansong
Copy link
Contributor

期望的方式是，当清空包含内容时，去掉当前的过滤条件，而不是包含“空值”，对吗？如果是的话，这一点可以改进。

@KANLON
Copy link
Contributor Author

KANLON commented Jul 27, 2022 •
edited
Loading

对的，另外主要是目前页面报错了

@Cuiyansong Cuiyansong added the improvement New feature or request label Jul 27, 2022
@Cuiyansong Cuiyansong added this to the RC.1 milestone Jul 27, 2022
Cuiyansong added a commit to Cuiyansong/datart that referenced this issue Jul 27, 2022
@Cuiyansong
fix: should not enable filter when value is empty or empty string, is…
eae4861 
…sue running-elephant#1754
@Cuiyansong Cuiyansong added the need signoff in pre-release Validating this bug label Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cuiyansong Cuiyansong

@SoarBlueSky SoarBlueSky

@qxqzx13 qxqzx13

Labels
discussion improvement New feature or request need signoff in pre-release Validating this bug
Projects
None yet
Milestone
RC.1
Development

No branches or pull requests
5 participants
@scottsut @Cuiyansong @KANLON @SoarBlueSky @qxqzx13