Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pivot table total and subtotal is hardcoded to chinese #1046

Closed
clementchong opened this issue Mar 18, 2022 · 4 comments · Fixed by #1061
Closed

Pivot table total and subtotal is hardcoded to chinese #1046

clementchong opened this issue Mar 18, 2022 · 4 comments · Fixed by #1061
Assignees
Labels
improvement New feature or request status: volunteer wanted Need more input from community.

Comments

@clementchong
Copy link
Contributor

Datart Version
The version of datart you using. 1.0.0b2

Describe the bug
A clear and concise description of what the bug is.
The Pivot creation -> Analysis tab has hardcoded chinese characters for total and subtotal positioning options. Once enabled, the total and subtotal descriptions are also displayed in chinese in the pivot table.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Vizs'
  2. Click on 'Pivot Table'
  3. Drag fields to Rows and Metrics to create any pivot table
  4. Click on Analysis tab
  5. Enable Row total and subtotal
  6. The dropdown options are in chinese. The pivot total and subtotal descriptions are also in chinese.

Expected behavior
A clear and concise description of what you expected to happen.
The mentioned chinese texts should be displayed in english in English viewing browsers.

Screenshots
If applicable, add screenshots to help explain your problem.

Environmental details: (optional, depending on where the bug occurs)

  • OS: [e.g. Windows 10] Windows 10
  • Source Database: [e.g. MySQL 8.0.26] MySQL 8.0.25
  • Browser: [e.g. chrome 94, safari 15] Chrome 99

Additional context
Add any other context about the problem here.
image

@clementchong
Copy link
Contributor Author

Prior posting this issue, I also spent some time trying to add i18n. Was able to do for the Analysis dropdown but could not locate the codes responsible for the total and subtotal descriptions in the pivot table. Any advice?

image

image

clementchong added a commit to clementchong/datart that referenced this issue Mar 18, 2022
@scottsut scottsut added improvement New feature or request volunteer wanted labels Mar 20, 2022
qxqzx13 added a commit that referenced this issue Mar 21, 2022
#1046: i18n for pivot table menu options
@clementchong
Copy link
Contributor Author

clementchong commented Mar 21, 2022

Any hint where to find the codes that generated the chinese text in pivot subtotal and total?

image

@scottsut scottsut linked a pull request Mar 22, 2022 that will close this issue
@scottsut
Copy link
Contributor

Any hint where to find the codes that generated the chinese text in pivot subtotal and total?

image

We have done this part in #1061 , but thanks anyway for your participation.

@clementchong
Copy link
Contributor Author

Great! Looking forward to it. Thank you!

@scottsut scottsut added status: volunteer wanted Need more input from community. and removed volunteer wanted labels Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or request status: volunteer wanted Need more input from community.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants