Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use isTypeAssertionExpression instead of the deprecated isTypeAssertion. #253

Closed
wants to merge 2 commits into from

Conversation

bicknellr
Copy link
Contributor

@bicknellr bicknellr commented Dec 19, 2022

Upstreams http://cl/495662713.

isTypeAssertionExpression was added in microsoft/TypeScript#35282 and deprecates isTypeAssertion. This package supports back to at least [email protected], so I've made this fall back to isTypeAssertion anyway.

@peschee
Copy link

peschee commented Mar 31, 2023

@bicknellr This link http://cl/495662713 does not seem to work. Is that a (google?) internal link?

@justinfagnani
Copy link
Collaborator

@peschee yes, that's a Google-internal code review tool.

@rictic
Copy link
Collaborator

rictic commented Jun 21, 2023

This change has been superceded

@rictic rictic closed this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants